tmrctr: initialize PWM and timer state variables#383
Open
FloofyJin wants to merge 1 commit into
Open
Conversation
Contributor
|
@FloofyJin Thanks for reporting it. We will check and fix if this turns to be a real issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
XTmrCtr_CfgInitialize() does not initialize IsStartedTmrCtr0, IsStartedTmrCtr1, or IsPwmEnabled.
When XTmrCtr instances are allocated on the stack, these members may contain indeterminate values.
This can cause XTmrCtr_PwmEnable() to return without enabling PWM because IsPwmEnabled is non-zero.
Reproduction:
The issue disappears if the application performs memset(&Timer, 0, sizeof(Timer)) prior to initialization. This patch initializes the driver state variables inside XTmrCtr_CfgInitialize() which will essentially do the same thing.